Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_autoscaling_group initial_lifecycle_hook set ForceNew: true #20708

Merged
merged 3 commits into from
Mar 25, 2022
Merged

aws_autoscaling_group initial_lifecycle_hook set ForceNew: true #20708

merged 3 commits into from
Mar 25, 2022

Conversation

nitrocode
Copy link
Contributor

@nitrocode nitrocode commented Aug 27, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19714
Closes #4714

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@github-actions github-actions bot added service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Aug 27, 2021
@nitrocode nitrocode changed the title asg initial_lifecycle_hook set ForceNew: true aws_autoscaling_group initial_lifecycle_hook set ForceNew: true Aug 27, 2021
@breathingdust breathingdust added bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2021
@nitrocode
Copy link
Contributor Author

cc: @breathingdust Friendly ping for this small PR. Could I please get a review or what I can do to get this approved?

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@nitrocode
Copy link
Contributor Author

@zhelding conflicts resolved :)

@nitrocode
Copy link
Contributor Author

@zhelding @breathingdust hi all, just a friendly bump. is there anything else i can do to get this in the next release?

@zhelding
Copy link
Contributor

Hi @nitrocode!

No further action is required on your part. We will now review your PR as part of our standard triage prioritization process (see here). Unfortunately, we can't guarantee that your PR will get a review in a timely manner, but we will get to it as soon as we have capacity.

Thanks again for your contribution!

@YakDriver YakDriver self-assigned this Mar 25, 2022
@YakDriver YakDriver force-pushed the asg-initial_lifecycle_hook-ForceNew branch from c416852 to 125e6c3 Compare March 25, 2022 18:11
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 25, 2022
YakDriver
YakDriver approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

% make testacc TESTS=TestAccAutoScalingGroup PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroup'  -timeout 180m
--- PASS: TestAccAutoScalingGroupDataSource_basic (47.33s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandAllocationStrategy (50.20s)
--- PASS: TestAccAutoScalingGroup_launchTemplate (54.07s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_launchTemplateName (59.79s)
--- PASS: TestAccAutoScalingGroup_LaunchTemplate_iamInstanceProfile (68.90s)
--- PASS: TestAccAutoScalingGroup_launchTempPartitionNum (72.32s)
--- PASS: TestAccAutoScalingGroup_classicVPCZoneIdentifier (76.04s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_updateToZeroOnDemandBaseCapacity (77.72s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceType (82.61s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateLaunchTemplateSpecification_version (88.10s)
--- PASS: TestAccAutoScalingGroup_mixedInstancesPolicy (47.59s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicy_capacityRebalance (46.60s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandPercentageAboveBaseCapacity (100.92s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotAllocationStrategy (53.29s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_instanceTypeWithLaunchTemplateSpecification (115.87s)
--- PASS: TestAccAutoScalingGroup_withPlacementGroup (128.40s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotMaxPrice (84.57s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_spotInstancePools (61.53s)
--- PASS: TestAccAutoScalingGroup_serviceLinkedRoleARN (40.75s)
--- PASS: TestAccAutoScalingGroup_Destroy_whenProtectedFromScaleIn (150.83s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyInstancesDistribution_onDemandBaseCapacity (154.99s)
--- PASS: TestAccAutoScalingGroup_namePrefix (48.50s)
--- PASS: TestAccAutoScalingGroup_maxInstanceLifetime (71.40s)
--- PASS: TestAccAutoScalingGroup_withMetrics (85.55s)
--- PASS: TestAccAutoScalingGroup_MixedInstancesPolicyLaunchTemplateOverride_weightedCapacity (195.36s)
--- PASS: TestAccAutoScalingGroup_LaunchTemplate_update (196.85s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (201.62s)
--- PASS: TestAccAutoScalingGroup_vpcUpdates (78.86s)
--- PASS: TestAccAutoScalingGroup_ALB_targetGroups (129.71s)
--- PASS: TestAccAutoScalingGroupTag_value (66.13s)
--- PASS: TestAccAutoScalingGroup_Name_generated (65.48s)
--- PASS: TestAccAutoScalingGroup_targetGroupARNs (142.47s)
--- PASS: TestAccAutoScalingGroupTag_basic (51.04s)
--- PASS: TestAccAutoScalingGroupTag_disappears (48.72s)
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (55.33s)
--- PASS: TestAccAutoScalingGroup_warmPool (283.03s)
--- PASS: TestAccAutoScalingGroup_enablingMetrics (171.11s)
--- PASS: TestAccAutoScalingGroup_terminationPolicies (120.62s)
--- PASS: TestAccAutoScalingGroup_suspendingProcesses (184.32s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (259.28s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (260.41s)
--- PASS: TestAccAutoScalingGroup_tags (238.03s)
--- PASS: TestAccAutoScalingGroup_withLoadBalancer (254.34s)
--- PASS: TestAccAutoScalingGroup_basic (232.32s)
--- PASS: TestAccAutoScalingGroup_ALBTargetGroups_elbCapacity (333.71s)
--- PASS: TestAccAutoScalingGroup_initialLifecycleHook (203.23s)
--- PASS: TestAccAutoScalingGroup_WithLoadBalancer_toTargetGroup (350.95s)
--- PASS: TestAccAutoScalingGroup_loadBalancers (402.54s)
--- PASS: TestAccAutoScalingGroupsDataSource_basic (43.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	472.730s

@YakDriver YakDriver merged commit 1af230d into hashicorp:main Mar 25, 2022
@github-actions github-actions bot added this to the v4.8.0 milestone Mar 25, 2022
@nitrocode nitrocode deleted the asg-initial_lifecycle_hook-ForceNew branch March 25, 2022 21:29
@github-actions
Copy link

This functionality has been released in v4.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.8.0
4 participants
@nitrocode @zhelding @YakDriver @breathingdust